Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 42624: Moving the mouse-wheel processing code out of the FocusManager (Closed)

Created:
11 years, 9 months ago by jcampan
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Relanding since it was breaking the Release build (because of missing includes). Moving the mouse-wheel message rerouting code out of the focus manager. This is part of the effort of making the focus manager not window specific. BUG=None TEST=Make sure mouse-wheel scrolls the Chrome window under the cursor (try with a Chrome window, the option window, the task manager table) when it is active and when it is inactive. Also try using the mouse-wheel on a plugin with a scroll-view (for example http://java.sun.com/products/plugin/1.4/demos/plugin/jfc/SwingSet2/SwingSet2.html) when the browser window is not active, the plugin should scroll. TBR=ben Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12517

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -115 lines) Patch
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/views/focus/focus_manager.cc View 2 chunks +0 lines, -107 lines 0 comments Download
A + chrome/views/focus/focus_util_win.h View 1 chunk +2 lines, -0 lines 0 comments Download
A + chrome/views/focus/focus_util_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/views/views.vcproj View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/views/widget/widget_win.h View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/views/widget/widget_win.cc View 3 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jcampan
11 years, 9 months ago (2009-03-25 23:19:46 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698