Issue 42622: Add an exception to DownloadManager::GenerateExtension() for .tar.gz files wi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42622: Add an exception to DownloadManager::GenerateExtension() for .tar.gz files wi... (Closed)

Created:
11 years, 9 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
sidchat (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add an exception to DownloadManager::GenerateExtension() for .tar.gz files with mime_type "application/x-tar". BUG=5772 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12509

Patch Set 1 #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -1 line)			Patch
	M	chrome/browser/download/download_manager.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
	M	chrome/browser/download/download_manager_unittest.cc	View		1 chunk	+16 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sidchat (Google)

11 years, 9 months ago (2009-03-25 22:09:35 UTC) #2

LGTM

http://codereview.chromium.org/42622/diff/1/2
File chrome/browser/download/download_manager_unittest.cc (right):

http://codereview.chromium.org/42622/diff/1/2#newcode316
Line 316: // For bug 5772
// Issue = 5772.

Expand Messages | Collapse Messages