Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 42622: Add an exception to DownloadManager::GenerateExtension() for .tar.gz files wi... (Closed)

Created:
11 years, 9 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
sidchat (Google)
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add an exception to DownloadManager::GenerateExtension() for .tar.gz files with mime_type "application/x-tar". BUG=5772 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12509

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M chrome/browser/download/download_manager.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/download/download_manager_unittest.cc View 1 chunk +16 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
11 years, 9 months ago (2009-03-25 21:51:14 UTC) #1
sidchat (Google)
11 years, 9 months ago (2009-03-25 22:09:35 UTC) #2
LGTM

http://codereview.chromium.org/42622/diff/1/2
File chrome/browser/download/download_manager_unittest.cc (right):

http://codereview.chromium.org/42622/diff/1/2#newcode316
Line 316: // For bug 5772
// Issue = 5772.

Powered by Google App Engine
This is Rietveld 408576698