Issue 42621: Moving WM_IME_CHAR handling out of the FocusManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42621: Moving WM_IME_CHAR handling out of the FocusManager (Closed)

Created:
11 years, 9 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
Hironori Bono

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

In an effort to make the FocusManager class platform independent, moving some Windows specific code around. BUG=9117 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12571

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
	M	chrome/views/controls/text_field.cc	View	1	3 chunks	+11 lines, -0 lines	0 comments	Download
	M	chrome/views/focus/focus_manager.cc	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

11 years, 9 months ago (2009-03-26 06:15:32 UTC) #2

LGTM.
This is just an experimental change to investigate that Issue 7707 is caused by
a WM_IME_CHAR message sent when we process a WM_IME_COMPOSTION message. So, if
this code fixes Issue 7707, your code also fixes it.

Expand Messages | Collapse Messages