Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 4262004: Fix signing script to work with new recovery image format. (Closed)

Created:
10 years, 1 month ago by gauravsh
Modified:
9 years, 6 months ago
Reviewers:
Will Drewry
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Fix signing script to work with new recovery image format. BUG=chrome-os-partner:1573 TEST=Manually tested with the latest signed release build. Recovery installer successfully completed and installed the image on the SSD. Change-Id: I92706e957a1d339db516600ef0d86141d914b0d2 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d7947a1

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : fix comment #

Patch Set 4 : better logging #

Patch Set 5 : 80 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -19 lines) Patch
M scripts/image_signing/sign_official_build.sh View 1 2 3 4 11 chunks +58 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gauravsh
10 years, 1 month ago (2010-11-02 22:49:58 UTC) #1
Will Drewry
At first glance, looks good!
10 years, 1 month ago (2010-11-02 23:03:36 UTC) #2
gauravsh
I tested the change and it works.
10 years, 1 month ago (2010-11-03 00:08:26 UTC) #3
Will Drewry
10 years, 1 month ago (2010-11-03 00:34:26 UTC) #4
LGTM!

Powered by Google App Engine
This is Rietveld 408576698