Issue 4262: Stop spamming delayed tasks on each input event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4262: Stop spamming delayed tasks on each input event. (Closed)

Created:
12 years, 3 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Stop spamming delayed tasks on each input event. R=mbelshe BUG=2693 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2609

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -28 lines)			Patch
M	base/timer.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/render_view_host.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/render_widget_host.h	View	1	6 chunks	+17 lines, -14 lines	0 comments	Download
M	chrome/browser/render_widget_host.cc	View		4 chunks	+32 lines, -10 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mike Belshe

12 years, 2 months ago (2008-09-25 16:01:05 UTC) #2

LGTM

http://codereview.chromium.org/4262/diff/205/9
File chrome/browser/render_widget_host.cc (right):

http://codereview.chromium.org/4262/diff/205/9#newcode822
Line 822: // We need to adjust the timer to fire sooner.
// Either the timer is not yet running, or we need
// to adjust the timer to fire sooner.

Expand Messages | Collapse Messages