Fixes bug where first login attempt to hotmail after session restore...

Fixes bug where first login attempt to hotmail after session restore
wouldn't work. The problem was we weren't storing post URLs at all
(because of bug 1361980). This resulted in session restore trying to
restore some redirects along the way that likely had bogus state in
them (perhaps referencing cookies that were nuked), resulting in the
first login failing. The fix is to persist POST URLs to disk for
session restore, but not the actual POST data. This way there
shouldn't be any problems as outlined in 1361980.

BUG=7727
TEST=see bug


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12568

[darin (slow to review), 2009-03-25 20:34:35]

http://codereview.chromium.org/42619/diff/1/3
File webkit/glue/glue_serialize.cc (right):

http://codereview.chromium.org/42619/diff/1/3#newcode338
Line 338: PassRefPtr<HistoryItem> HistoryItemFromString(
do we need this second version of the function?  can't we just update all
callers to use the new one?

http://codereview.chromium.org/42619/diff/1/3#newcode370
Line 370: std::string RemoveFormState(const std::string& content_state) {
nit: maybe call this RemoveFormData to better correspond to the
"include_form_data" parameter and the data structure named FormData?

http://codereview.chromium.org/42619/diff/1/2
File webkit/glue/webkit_glue.h (right):

http://codereview.chromium.org/42619/diff/1/2#newcode88
Line 88: std::string RemoveFormState(const std::string& content_state);
maybe include the word "HistoryState" in this function? 
RemoveFormDataFromHistoryState perhaps?

[sky, 2009-03-26 15:52:23]

New version uploaded.

http://codereview.chromium.org/42619/diff/1/3
File webkit/glue/glue_serialize.cc (right):

http://codereview.chromium.org/42619/diff/1/3#newcode338
Line 338: PassRefPtr<HistoryItem> HistoryItemFromString(
On 2009/03/25 20:34:35, darin wrote:
> do we need this second version of the function?  can't we just update all
> callers to use the new one?

I went this route as the second form is only needed inside this file and I
didn't want folks to have to think about what include_form_data means. If you
feel strongly though, I'll nuke the second variant.

http://codereview.chromium.org/42619/diff/1/2
File webkit/glue/webkit_glue.h (right):

http://codereview.chromium.org/42619/diff/1/2#newcode88
Line 88: std::string RemoveFormState(const std::string& content_state);
On 2009/03/25 20:34:35, darin wrote:
> maybe include the word "HistoryState" in this function? 
> RemoveFormDataFromHistoryState perhaps?

I was trying not to be so verbose, but I agree it is more descriptive. Updated.

[darin (slow to review), 2009-03-26 17:03:48]

LGTM

http://codereview.chromium.org/42619/diff/7/1007
File webkit/glue/glue_serialize.cc (right):

http://codereview.chromium.org/42619/diff/7/1007#newcode338
Line 338: PassRefPtr<HistoryItem> HistoryItemFromString(
nit: since this function is only used in this file, please mark it 'static'

[Dean McNamee, 2009-03-27 11:33:35]

Does this mean when we session restore, we do a POST, but without any POST data,
or that we do a GET?