Issue 4261001: Moving Entry from base::file_util_proxy namespace to within class base::FileU...

Issue 4261001: Moving Entry from base::file_util_proxy namespace to within class base::FileU... (Closed)

Created:
10 years, 1 month ago by Kavita Kanetkar

Modified:
9 years, 7 months ago

Reviewers:
kinuko, darin (slow to review)

CC:
chromium-reviews, jam, ben+cc_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Moving Entry from base::file_util_proxy namespace to within class base::FileUtilProxy BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64806

Patch Set 2 : '' #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -79 lines)			Patch
M	base/file_util_proxy.h	View	1	11 chunks	+28 lines, -34 lines	2 comments	Download
M	base/file_util_proxy.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/file_system/browser_file_system_callback_dispatcher.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/file_system/browser_file_system_callback_dispatcher.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/file_system/file_system_dispatcher.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/file_system/file_system_dispatcher.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/file_system/webfilesystem_callback_dispatcher.h	View	1	2 chunks	+1 line, -7 lines	0 comments	Download
M	chrome/common/file_system/webfilesystem_callback_dispatcher.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/file_system/webfilewriter_impl.cc	View	1	3 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View		3 chunks	+2 lines, -7 lines	0 comments	Download
M	chrome/common/render_messages_params.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/render_messages_params.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	webkit/fileapi/file_system_callback_dispatcher.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	webkit/fileapi/file_system_operation.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/fileapi/file_system_operation.cc	View	1	3 chunks	+5 lines, -3 lines	0 comments	Download
M	webkit/fileapi/file_system_operation_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	webkit/glue/plugins/pepper_file_callbacks.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/plugins/pepper_file_callbacks.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/simple_file_system.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/simple_file_writer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kinuko

LGTM http://codereview.chromium.org/4261001/diff/30001/16004 File base/file_util_proxy.h (right): http://codereview.chromium.org/4261001/diff/30001/16004#newcode25 base/file_util_proxy.h:25: // Holds metadata for file or directory entry. ...

10 years, 1 month ago (2010-11-02 03:31:52 UTC) #2

darin (slow to review)

10 years, 1 month ago (2010-11-02 18:08:34 UTC) #3

On 2010/11/02 03:31:52, Kinuko Yasuda wrote:
> LGTM

LGTM2 w/ same nits

Expand Messages | Collapse Messages