Issue 42593: Add a gtk_clipboard_dump target with a new .gyp file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42593: Add a gtk_clipboard_dump target with a new .gyp file. (Closed)

Created:
11 years, 9 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a gtk_clipboard_dump target with a new .gyp file. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12454

Patch Set 1 #

Total comments: 2

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
	M	build/all.gyp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	A	tools/gtk_clipboard_dump/gtk_clipboard_dump.gyp	View		1 chunk	+17 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sgk

(Got the right file(s) hooked up with the right subject line this time.)

11 years, 9 months ago (2009-03-25 05:53:38 UTC) #1

Mark Mentovai

LGTM http://codereview.chromium.org/42593/diff/1/3 File tools/gtk_clipboard_dump/gtk_clipboard_dump.gyp (right): http://codereview.chromium.org/42593/diff/1/3#newcode1 Line 1: { Be sure to set svn:eol-style

11 years, 9 months ago (2009-03-25 13:19:35 UTC) #2

sgk

11 years, 9 months ago (2009-03-25 15:21:43 UTC) #3

http://codereview.chromium.org/42593/diff/1/3
File tools/gtk_clipboard_dump/gtk_clipboard_dump.gyp (right):

http://codereview.chromium.org/42593/diff/1/3#newcode1
Line 1: {
On 2009/03/25 13:19:35, Mark Mentovai wrote:
> Be sure to set svn:eol-style

Done.

Expand Messages | Collapse Messages