Issue 42573: Prevent data read errors from crashing the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42573: Prevent data read errors from crashing the browser. (Closed)

Created:
11 years, 9 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Prevent data read errors from crashing the browser. In ResourceDispatcherHost::OnResponseStarted(), if Read() causes an error, it calls OnResponseCompleted(). For a download, this hits the NOTREACHED() in DownloadThrottlingResourceHandler::OnResponseCompleted(). This patch checks for the error status, and returns false, which causes the download to finish, which saves an empty file of size 0. BUG=8170 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12410

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	chrome/browser/renderer_host/download_throttling_resource_handler.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

Scott, can you take a look at this one? You originally wrote the code in ...

11 years, 9 months ago (2009-03-24 21:21:48 UTC) #1

sky

11 years, 9 months ago (2009-03-24 21:35:45 UTC) #2

LGTM, just add a comment and update the spacing.

http://codereview.chromium.org/42573/diff/1/2
File chrome/browser/renderer_host/download_throttling_resource_handler.cc
(right):

http://codereview.chromium.org/42573/diff/1/2#newcode108
Line 108: return false;
Can you add a comment here saying we can get this if the response fails right
away?

nit: spacing is off

Expand Messages | Collapse Messages