Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 42569: Adding a Set() method for copying a variant over to the ScopedVariant.... (Closed)

Created:
11 years, 9 months ago by tommi (sloooow) - chröme
Modified:
9 years, 7 months ago
Reviewers:
amit
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Adding a Set() method for copying (not taking ownership) a variant over to the ScopedVariant and a couple of new constructors for IDispatch and IUnknown. includes tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12506

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -0 lines) Patch
M base/scoped_variant_win.h View 1 2 3 chunks +18 lines, -0 lines 0 comments Download
M base/scoped_variant_win.cc View 1 2 2 chunks +31 lines, -0 lines 0 comments Download
M base/scoped_variant_win_unittest.cc View 1 2 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tommi (sloooow) - chröme
11 years, 9 months ago (2009-03-24 18:48:37 UTC) #1
amit
lgtm
11 years, 9 months ago (2009-03-24 20:33:15 UTC) #2
amit
11 years, 9 months ago (2009-03-25 21:43:05 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698