src/codegen-ia32.cc - Issue 42565: Remove register counts from VirtualFrame, use register indices instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codegen-ia32.cc

Issue 42565: Remove register counts from VirtualFrame, use register indices instead. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 11 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/codegen-ia32.cc

===================================================================

--- src/codegen-ia32.cc (revision 1604)

+++ src/codegen-ia32.cc (working copy)

@@ -5163,11 +5163,11 @@

#ifdef DEBUG

bool CodeGenerator::HasValidEntryRegisters() {

- return (allocator()->count(eax) == frame()->register_count(eax))

- && (allocator()->count(ebx) == frame()->register_count(ebx))

- && (allocator()->count(ecx) == frame()->register_count(ecx))

- && (allocator()->count(edx) == frame()->register_count(edx))

- && (allocator()->count(edi) == frame()->register_count(edi));

+ return (allocator()->count(eax) == (frame()->is_used(eax) ? 1 : 0))

+ && (allocator()->count(ebx) == (frame()->is_used(ebx) ? 1 : 0))

+ && (allocator()->count(ecx) == (frame()->is_used(ecx) ? 1 : 0))

+ && (allocator()->count(edx) == (frame()->is_used(edx) ? 1 : 0))

+ && (allocator()->count(edi) == (frame()->is_used(edi) ? 1 : 0));

}

#endif

« no previous file with comments | « no previous file | src/jump-target.cc » ('j') | no next file with comments »