Issue 42559: Remove stl dependencies from d8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42559: Remove stl dependencies from d8. (Closed)

Created:
11 years, 9 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Remove stl dependencies from d8. Committed: http://code.google.com/p/v8/source/detail?r=1599

Patch Set 1 #

Total comments: 2

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -20 lines)			Patch
M	src/d8.h	View	3 chunks	+39 lines, -7 lines	0 comments	Download
M	src/d8.cc	View	4 chunks	+27 lines, -11 lines	1 comment	Download
M	src/date-delay.js	View	1 chunk	+2 lines, -0 lines	1 comment	Download
M	src/serialize.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

11 years, 9 months ago (2009-03-24 13:29:30 UTC) #2

LGTM.

http://codereview.chromium.org/42559/diff/1/3
File src/d8.cc (right):

http://codereview.chromium.org/42559/diff/1/3#newcode100
Line 100: return !strcmp(name1, name2);
return strcmp(name1, name2) == 0; maybe?

http://codereview.chromium.org/42559/diff/1/2
File src/date-delay.js (right):

http://codereview.chromium.org/42559/diff/1/2#newcode411
Line 411: if (IS_DATE(aDate)) foo = %_ValueOf(aDate);
Hvabehar?

Expand Messages | Collapse Messages