Issue 42555: Added a test for debugger agent protocol message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42555: Added a test for debugger agent protocol message (Closed)

Created:
11 years, 9 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Added a test for debugger agent protocol message. Committed: http://code.google.com/p/v8/source/detail?r=1590

Patch Set 2 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -3 lines)			Patch
	M	test/cctest/test-debug.cc	View	1	2 chunks	+120 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/42555/diff/1/2 File test/cctest/test-debug.cc (right): http://codereview.chromium.org/42555/diff/1/2#newcode3924 Line 3924: const int kPortBuferLen = 6; Bufer -> ...

11 years, 9 months ago (2009-03-24 10:26:58 UTC) #2

Søren Thygesen Gjesse

11 years, 9 months ago (2009-03-24 10:41:33 UTC) #3

http://codereview.chromium.org/42555/diff/1/2
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/42555/diff/1/2#newcode3924
Line 3924: const int kPortBuferLen = 6;
On 2009/03/24 10:26:58, Erik Corry wrote:
> Bufer -> Buffer

Done.

http://codereview.chromium.org/42555/diff/1/2#newcode3943
Line 3943: // Send headers which overflows the receive buffer.
On 2009/03/24 10:26:58, Erik Corry wrote:
> overflows -> overflow

Done.

Expand Messages | Collapse Messages

Issue 42555: Added a test for debugger agent protocol message (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages