Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 4255001: Revert 64672 - Cleanups in the video encoding decoding code. Reenable VP8.... (Closed)

Created:
10 years, 1 month ago by Sergey Ulanov
Modified:
9 years, 7 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, Alpha Left Google, Sergey Ulanov, dmac, pam+watch_chromium.org, awong, garykac, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 64672 - Cleanups in the video encoding decoding code. Reenable VP8. 1. Moved video-related protobuf messages from event.proto to video.proto. Removed those that we don't need anymore 2. Fixed naming for enums and some types. 3. Reenabled VP8. 4. Proper RGB-YUV converter for VP8 encoder. 5. Changed the capturer_fake to show more meaningful picture. BUG=57374 TEST=unittests Review URL: http://codereview.chromium.org/4136010 TBR=sergeyu@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64677

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+510 lines, -424 lines) Patch
M remoting/base/capture_data.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/codec_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M remoting/base/decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/base/decoder_row_based.h View 3 chunks +3 lines, -4 lines 0 comments Download
M remoting/base/decoder_row_based.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M remoting/base/decoder_vp8.h View 1 chunk +21 lines, -18 lines 0 comments Download
M remoting/base/decoder_vp8.cc View 4 chunks +86 lines, -28 lines 0 comments Download
M remoting/base/encoder.h View 1 chunk +12 lines, -1 line 0 comments Download
M remoting/base/encoder_verbatim.h View 1 chunk +4 lines, -3 lines 0 comments Download
M remoting/base/encoder_verbatim.cc View 2 chunks +29 lines, -15 lines 0 comments Download
M remoting/base/encoder_vp8.cc View 7 chunks +30 lines, -47 lines 0 comments Download
M remoting/base/encoder_zlib.h View 1 chunk +4 lines, -3 lines 0 comments Download
M remoting/base/encoder_zlib.cc View 4 chunks +36 lines, -20 lines 0 comments Download
M remoting/base/multiple_array_input_stream_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/base/util.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/util.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M remoting/client/chromoting_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/client/chromoting_view_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/client/rectangle_update_decoder.h View 2 chunks +6 lines, -6 lines 0 comments Download
M remoting/client/rectangle_update_decoder.cc View 7 chunks +17 lines, -19 lines 0 comments Download
M remoting/host/capturer.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/capturer_fake.h View 2 chunks +4 lines, -5 lines 0 comments Download
M remoting/host/capturer_fake.cc View 3 chunks +12 lines, -46 lines 0 comments Download
M remoting/host/capturer_fake_ascii.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/capturer_gdi.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/capturer_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/capturer_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/client_connection.h View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/client_connection.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M remoting/host/client_connection_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/mock_objects.h View 1 chunk +4 lines, -1 line 0 comments Download
M remoting/host/session_manager.h View 3 chunks +6 lines, -3 lines 0 comments Download
M remoting/host/session_manager.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M remoting/host/session_manager_unittest.cc View 3 chunks +11 lines, -7 lines 0 comments Download
M remoting/host/simple_host_process.cc View 5 chunks +5 lines, -24 lines 0 comments Download
M remoting/proto/chromotocol.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M remoting/proto/event.proto View 2 chunks +136 lines, -1 line 0 comments Download
M remoting/proto/internal.proto View 2 chunks +5 lines, -3 lines 0 comments Download
D remoting/proto/video.proto View 1 chunk +0 lines, -93 lines 0 comments Download
M remoting/protocol/host_message_dispatcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/message_decoder_unittest.cc View 2 chunks +28 lines, -7 lines 0 comments Download
M remoting/remoting.gyp View 4 chunks +6 lines, -16 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Sergey Ulanov
10 years, 1 month ago (2010-11-01 23:02:29 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698