Issue 4252002: address comments in CL 4054001

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4252002: address comments in CL 4054001 (Closed)

Created:
10 years, 1 month ago by oshima

Modified:
9 years, 6 months ago

Reviewers:
whywhat

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Updated include guard name Moved constants to anonymous namespace. BUG=chromium-os:5763 TEST=none. no functional/visual change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64765

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -11 lines)			Patch
	M	chrome/browser/chromeos/login/shutdown_button.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
	M	chrome/browser/chromeos/login/shutdown_button.cc	View		2 chunks	+15 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

whywhat

LGTM btw, shutdown button is visible on profile picture taking screen, is it intentional?

10 years, 1 month ago (2010-11-02 06:01:40 UTC) #2

oshima

10 years, 1 month ago (2010-11-04 00:59:27 UTC) #3

On 2010/11/02 06:01:40, whywhat wrote:
> LGTM
> 
> btw, shutdown button is visible on profile picture taking screen, is it
> intentional?

is it? It shoudln't, but if it does, can you file a bug?

Expand Messages | Collapse Messages