Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6154)

Unified Diff: chrome/browser/errorpage_uitest.cc

Issue 4251003: Marking ErrorPageTest.IFrame404 as flaky on Windows builders, probably relate... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/errorpage_uitest.cc
===================================================================
--- chrome/browser/errorpage_uitest.cc (revision 64609)
+++ chrome/browser/errorpage_uitest.cc (working copy)
@@ -163,7 +163,14 @@
EXPECT_TRUE(WaitForTitleMatching(L"Blah"));
}
-TEST_F(ErrorPageTest, IFrame404) {
+#if defined(OS_WIN)
+// Might be related to http://crbug.com/60937
+#define MAYBE_IFrame404 FLAKY_IFrame404
+#else
+#define MAYBE_IFrame404 IFrame404
+#endif
+
+TEST_F(ErrorPageTest, MAYBE_IFrame404) {
// iframes that have 404 pages should not trigger an alternate error page.
// In this test, the iframe sets the title of the parent page to "SUCCESS"
// when the iframe loads. If the iframe fails to load (because an alternate
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698