Issue 42508: Fix bug in context stores, where the store was ignored if there was a...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42508: Fix bug in context stores, where the store was ignored if there was a... (Closed)

Created:
11 years, 9 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix bug in context stores, where the store was ignored if there was a read-only property in the prototype chain. Stores should only be ignored if there is a read-only property on the object itself. Committed: http://code.google.com/p/v8/source/detail?r=1584

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+121 lines, -2 lines)			Patch
M	src/runtime.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+23 lines, -0 lines	0 comments	Download
A	test/mjsunit/getter-in-prototype.js	View	1 chunk	+50 lines, -0 lines	0 comments	Download
A	test/mjsunit/with-prototype.js	View	1 chunk	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages