Issue 425010: implement SysInfo::MaxSharedMemorySize for openbsd using...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 425010: implement SysInfo::MaxSharedMemorySize for openbsd using... (Closed)

Created:
11 years, 1 month ago by pvalchev

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, djm

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, brettw+cc_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

implement SysInfo::MaxSharedMemorySize for openbsd using the appropriate sysctl's (based on systat code)

Patch Set 3 : '' #

Total comments: 2

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -0 lines)			Patch
	M	base/sys_info_posix.cc	View		2 chunks	+31 lines, -0 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pvalchev

Another independent small change that shouldn't affect the FreeBSD patch (can't wait for that one ...

11 years, 1 month ago (2009-11-21 00:02:19 UTC) #1

Evan Martin

I have a change that will conflict with this but the fix will be obvious ...

11 years, 1 month ago (2009-11-21 03:39:54 UTC) #2

djm

http://codereview.chromium.org/425010/diff/2002/2003 File base/sys_info_posix.cc (right): http://codereview.chromium.org/425010/diff/2002/2003#newcode198 base/sys_info_posix.cc:198: struct shm_sysctl_info *shmsi = (struct shm_sysctl_info *)buf; Why do ...

11 years ago (2009-12-09 02:25:58 UTC) #3

pvalchev

11 years ago (2009-12-09 19:08:22 UTC) #4

Is this still pending?

Expand Messages | Collapse Messages

Issue 425010: implement SysInfo::MaxSharedMemorySize for openbsd using... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages