Issue 4250: Fix a crash when a frame was inserted into a popup and navigated. I added a...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4250: Fix a crash when a frame was inserted into a popup and navigated. I added a... (Closed)

Created:
12 years, 3 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
huanr

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a crash when a frame was inserted into a popup and navigated. I added a test for this case. I also checked the other navigation cases to see if we were relying on state from the renderer (which might be malicious) and the controller being in sync, and I didn't see any others in this area. I clarified some comments so it should be more clearly correct. BUG=1279570 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2549

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -8 lines)			Patch
	M	chrome/browser/navigation_controller.cc	View		5 chunks	+25 lines, -8 lines	0 comments	Download
	M	chrome/browser/navigation_controller_unittest.cc	View		1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages