Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 4248: Make sure that the body of the function created by calling Function is... (Closed)

Created:
12 years, 3 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
plesner
CC:
v8-dev
Visibility:
Public.

Description

Make sure that the body of the function created by calling Function is on a line of its own. This allows the body to be terminated by a single-line comment. Also, make sure to set the name of the function to anonymous after the fact so that recursion through the name anonymous is not allowed and so that global variables called anonymous are not shadowed. This is a fix for http://code.google.com/p/v8/issues/detail?id=85 Committed: http://code.google.com/p/v8/source/detail?r=370

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -27 lines) Patch
M src/compiler.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/debug-delay.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/runtime.h View 2 2 chunks +2 lines, -1 line 0 comments Download
M src/runtime.cc View 2 5 chunks +18 lines, -6 lines 0 comments Download
M src/v8natives.js View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M test/mjsunit/function.js View 1 2 2 chunks +21 lines, -10 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Mads Ager (chromium)
12 years, 3 months ago (2008-09-24 08:31:52 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698