Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: chrome/browser/history/text_database_unittest.cc

Issue 4247: Port some things in browser/{download,history}, minor things in common.... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/text_database_manager.cc ('k') | chrome/browser/history/thumbnail_database.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/text_database_unittest.cc
===================================================================
--- chrome/browser/history/text_database_unittest.cc (revision 2786)
+++ chrome/browser/history/text_database_unittest.cc (working copy)
@@ -202,7 +202,7 @@
EXPECT_TRUE(unique_urls.empty()) << "Didn't ask for unique URLs";
// All 3 sites should be returned in order.
- ASSERT_EQ(3, results.size());
+ ASSERT_EQ(3U, results.size());
EXPECT_EQ(GURL(kURL1), results[2].url);
EXPECT_EQ(GURL(kURL2), results[1].url);
EXPECT_EQ(GURL(kURL3), results[0].url);
@@ -217,9 +217,9 @@
EXPECT_EQ(UTF8ToWide(std::string(kTitle3)), results[0].title);
// Should have no matches in the title.
- EXPECT_EQ(0, results[0].title_match_positions.size());
- EXPECT_EQ(0, results[1].title_match_positions.size());
- EXPECT_EQ(0, results[2].title_match_positions.size());
+ EXPECT_EQ(0U, results[0].title_match_positions.size());
+ EXPECT_EQ(0U, results[1].title_match_positions.size());
+ EXPECT_EQ(0U, results[2].title_match_positions.size());
// We don't want to be dependent on the exact snippet algorithm, but we know
// since we searched for "COUNTTAG" which occurs at the beginning of each
@@ -253,7 +253,7 @@
EXPECT_TRUE(unique_urls.empty()) << "Didn't ask for unique URLs";
// The first and second should have been returned.
- EXPECT_EQ(2, results.size());
+ EXPECT_EQ(2U, results.size());
EXPECT_TRUE(ResultsHaveURL(results, kURL1));
EXPECT_TRUE(ResultsHaveURL(results, kURL2));
EXPECT_FALSE(ResultsHaveURL(results, kURL3));
@@ -273,7 +273,7 @@
first_time_searched.ToInternalValue());
// Should have two results, the second and third.
- EXPECT_EQ(2, results.size());
+ EXPECT_EQ(2U, results.size());
EXPECT_FALSE(ResultsHaveURL(results, kURL1));
EXPECT_TRUE(ResultsHaveURL(results, kURL2));
EXPECT_TRUE(ResultsHaveURL(results, kURL3));
@@ -311,7 +311,7 @@
EXPECT_TRUE(unique_urls.empty()) << "Didn't ask for unique URLs";
// There should be one result, the most recent one.
- EXPECT_EQ(1, results.size());
+ EXPECT_EQ(1U, results.size());
EXPECT_TRUE(ResultsHaveURL(results, kURL2));
// The max time considered should be the date of the returned item.
« no previous file with comments | « chrome/browser/history/text_database_manager.cc ('k') | chrome/browser/history/thumbnail_database.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698