Port some things in browser/{download,history}, minor things in common....

chrome/browser/history/text_database_manager.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/text_database_manager.h"
 
+#include "base/compiler_specific.h"
 #include "base/file_util.h"
 #include "base/histogram.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/string_util.h"
 #include "chrome/common/mru_cache.h"
 
 namespace history {
 
 namespace {
@@ skipping 46 matching lines @@
 
 TextDatabaseManager::TextDatabaseManager(const std::wstring& dir,
                                          VisitDatabase* visit_database)
     : dir_(dir),
       db_(NULL),
       visit_database_(visit_database),
       recent_changes_(RecentChangeList::NO_AUTO_EVICT),
       transaction_nesting_(0),
       db_cache_(DBCache::NO_AUTO_EVICT),
       present_databases_loaded_(false),
-#pragma warning(suppress: 4355)  // Okay to pass "this" here.
-      factory_(this) {
+      ALLOW_THIS_IN_INITIALIZER_LIST(factory_(this)) {
 }
 
 TextDatabaseManager::~TextDatabaseManager() {
   if (transaction_nesting_)
     CommitTransaction();
 }
 
 // static
 TextDatabase::DBIdent TextDatabaseManager::TimeToID(Time time) {
   Time::Exploded exploded;
@@ skipping 392 matching lines @@
     AddPageData(i->first, i->second.url_id(), i->second.visit_id(),
                 i->second.visit_time(), i->second.title(), i->second.body());
     i = recent_changes_.Erase(i);
   }
 
   ScheduleFlushOldChanges();
 }
 
 }  // namespace history