Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 42466: Light-weight External objects (Closed)

Created:
11 years, 9 months ago by iposva
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

- Do not allocate proxy objects if the pointer can be wrapped in a Smi representation. Committed: http://code.google.com/p/v8/source/detail?r=1568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M include/v8.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/api.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/api.cc View 3 chunks +13 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
iposva
11 years, 9 months ago (2009-03-20 21:32:41 UTC) #1
Mads Ager (chromium)
11 years, 9 months ago (2009-03-20 21:39:28 UTC) #2
LGTM

I think we might be doing this manually in the chromium binding layer.  With
this change, we should be able to simplify that.

Powered by Google App Engine
This is Rietveld 408576698