Issue 42460: Adds a bookmark menu. This is experimental. To turn on you need...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42460: Adds a bookmark menu. This is experimental. To turn on you need... (Closed)

Created:
11 years, 9 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Adds a bookmark menu. This is experimental. To turn on you need --bookmark-menu. BUG=3206 TEST=Turn on the bookmark menu via --bookmark-menu and make sure it works. Also make sure I didn't break anything on the bookmark bar. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12217

Patch Set 1 #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+302 lines, -9 lines)			Patch
A	chrome/app/theme/menu_bookmark.png	View	Binary file		0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_menu_controller.h	View	3 chunks	+9 lines, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_menu_controller.cc	View	5 chunks	+28 lines, -3 lines	0 comments	Download
M	chrome/browser/view_ids.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/views/bookmark_bar_view.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A	chrome/browser/views/bookmark_menu_button.h	View	1 chunk	+79 lines, -0 lines	1 comment	Download
A	chrome/browser/views/bookmark_menu_button.cc	View	1 chunk	+145 lines, -0 lines	0 comments	Download
M	chrome/browser/views/browser_views.vcproj	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/views/toolbar_view.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/views/toolbar_view.cc	View	5 chunks	+18 lines, -3 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/views/controls/button/menu_button.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jcampan

11 years, 9 months ago (2009-03-20 21:16:47 UTC) #2

LGTM

http://codereview.chromium.org/42460/diff/1/8
File chrome/browser/views/bookmark_menu_button.h (right):

http://codereview.chromium.org/42460/diff/1/8#newcode52
Line 52: // If the timer for showing the drop menu isn't running, it's started.
Nit: "Starts the timer for showing the drop menu if it isn't running" would
sound clearer (hey, I am no native speaker, so feel free to ignore this).

Expand Messages | Collapse Messages