Issue 4245002: Add instant to tabbed options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4245002: Add instant to tabbed options. (Closed)

Created:
10 years, 1 month ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add instant to tabbed options. It needs to launch a confirmation dialog, which it doesn't do yet. BUG=61042 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64966

Patch Set 2 : smorgan review #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -19 lines)			Patch
M	chrome/browser/dom_ui/options/advanced_options_handler.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/dom_ui/options/browser_options_handler.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/dom_ui.css	View	1	1 chunk	+8 lines, -1 line	0 comments	Download
M	chrome/browser/resources/new_new_tab.css	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/options/advanced_options.html	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options/browser_options.html	View	1	1 chunk	+21 lines, -7 lines	0 comments	Download
M	chrome/browser/resources/options/browser_options_page.css	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

http://codereview.chromium.org/4245002/diff/1/4 File chrome/browser/resources/dom_ui.css (right): http://codereview.chromium.org/4245002/diff/1/4#newcode41 chrome/browser/resources/dom_ui.css:41: .vbox { This is generally not recommended; CSS classes ...

10 years, 1 month ago (2010-11-02 23:17:58 UTC) #2

LGTM

Expand Messages | Collapse Messages

Issue 4245002: Add instant to tabbed options. (Closed)

Description

Patch Set 1 #

Patch Set 2 : smorgan review #

Messages