iccjpeg library

iccjpeg library for jpeg color profiles
BUG=61627
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64817

[fbarchard, 2010-11-02 19:50:20]

Initial drop of icc library for jpeg

[abarth-chromium, 2010-11-02 19:51:36]

Do we need a gyp file to actually build this code?

[pascal.massimino, 2010-11-02 19:55:35]

On 2010/11/02 19:51:36, abarth wrote:
> Do we need a gyp file to actually build this code?

i'd say yes, even if unsure about how Webkit's DEPS works...

[fbarchard, 2010-11-02 20:03:16]

On 2010/11/02 19:51:36, abarth wrote:
> Do we need a gyp file to actually build this code?

Done

[abarth-chromium, 2010-11-02 20:03:23]

On 2010/11/02 19:55:35, pascal.massimino wrote:
> i'd say yes, even if unsure about how Webkit's DEPS works...

It's the same as Chromium's DEPS.  :)  Maybe look at libjpeg's gyp for
inspiration?

[fbarchard, 2010-11-02 20:18:55]

added gyps.  kept it a simple library

[abarth-chromium, 2010-11-02 21:23:06]

LGTM with the nits below.

http://codereview.chromium.org/4244005/diff/22001/23001
File build/all.gyp (right):

http://codereview.chromium.org/4244005/diff/22001/23001#newcode35
build/all.gyp:35: '../third_party/iccjpeg/iccjpeg.gyp:*',
These seem to be alphabetical.  Maybe move it upwards a couple lines?

http://codereview.chromium.org/4244005/diff/22001/23002
File chrome/chrome.gyp (right):

http://codereview.chromium.org/4244005/diff/22001/23002#newcode1634
chrome/chrome.gyp:1634: '../third_party/iccjpeg/iccjpeg.gyp:*',
Same comment here.

[fbarchard, 2010-11-02 21:31:24]

Done.  applied sort to thirdparty
Try bots are green.  Local builds on Windows worked too.
Requires review by chromium developer

[abarth-chromium, 2010-11-02 21:32:11]

On 2010/11/02 21:31:24, fbarchard wrote:
> Requires review by chromium developer

I'm a Chromium developer.  :)

[fbarchard, 2010-11-03 17:12:48]

Will you guys be using iccjpeg for this bug:
http://code.google.com/p/chromium/issues/detail?id=143
<http://code.google.com/p/chromium/issues/detail?id=143>

On Tue, Nov 2, 2010 at 2:32 PM, <abarth@chromium.org> wrote:

> On 2010/11/02 21:31:24, fbarchard wrote:
>
>> Requires review by chromium developer
>>
>
> I'm a Chromium developer.  :)
>
>
> http://codereview.chromium.org/4244005/show
>

[Peter Kasting, 2010-11-03 17:15:20]

On 2010/11/03 17:12:48, fbarchard wrote:
> Will you guys be using iccjpeg for this bug:
> http://code.google.com/p/chromium/issues/detail?id=143

Yes.