Issue 4244003: Remove old preparser option and behavior from the parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4244003: Remove old preparser option and behavior from the parser. (Closed)

Created:
10 years, 1 month ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Remove old preparser option and behavior from the parser.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review comment + cleanup. #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+353 lines, -640 lines)			Patch
M	src/compiler.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/parser.h	View	1	12 chunks	+88 lines, -92 lines	0 comments	Download
M	src/parser.cc	View	1	101 chunks	+265 lines, -546 lines	0 comments	Download
M	src/scanner.h	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 1 month ago (2010-11-02 11:37:54 UTC) #2

LGTM

http://codereview.chromium.org/4244003/diff/1/4
File src/parser.h (right):

http://codereview.chromium.org/4244003/diff/1/4#newcode726
src/parser.h:726: Vector<const char> string);
Indentation.

Expand Messages | Collapse Messages