AU: Delta diff generator shows progress % when generating full updates.

AU: Delta diff generator shows progress % when generating full updates.

BUG=8646
TEST=unit tests, updated through dev server

Change-Id: If9ec724032d6f713433c9868f9fab5b12b292f2e

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=bc58a7b

[adlr, 2010-11-03 18:41:51]

LGTM w/ a thought about if we're still producing too much output

http://codereview.chromium.org/4243006/diff/2001/3001
File delta_diff_generator.cc (right):

http://codereview.chromium.org/4243006/diff/2001/3001#newcode1381
delta_diff_generator.cc:1381: LOG(INFO) << StringPrintf("%.1f", offset * 100.0 /
part_sizes[partition])
how many lines does this produce? Maybe we should print a line less than every
chunk?

[petkov, 2010-11-03 18:43:54]

http://codereview.chromium.org/4243006/diff/2001/3001
File delta_diff_generator.cc (right):

http://codereview.chromium.org/4243006/diff/2001/3001#newcode1381
delta_diff_generator.cc:1381: LOG(INFO) << StringPrintf("%.1f", offset * 100.0 /
part_sizes[partition])
On 2010/11/03 18:41:51, adlr wrote:
> how many lines does this produce? Maybe we should print a line less than every
> chunk?

850 I guess? I'm OK with verbose output as long as it can be interpreted by
random devs.

[adlr, 2010-11-03 18:48:28]

heh. LGTM

On Wed, Nov 3, 2010 at 11:43 AM, <petkov@chromium.org> wrote:

>
> http://codereview.chromium.org/4243006/diff/2001/3001
> File delta_diff_generator.cc (right):
>
> http://codereview.chromium.org/4243006/diff/2001/3001#newcode1381
> delta_diff_generator.cc:1381: LOG(INFO) << StringPrintf("%.1f", offset *
> 100.0 / part_sizes[partition])
> On 2010/11/03 18:41:51, adlr wrote:
>
>> how many lines does this produce? Maybe we should print a line less
>>
> than every
>
>> chunk?
>>
>
> 850 I guess? I'm OK with verbose output as long as it can be interpreted
> by random devs.
>
>
> http://codereview.chromium.org/4243006/show
>

[petkov, 2010-11-03 18:51:31]

On 2010/11/03 18:48:28, adlr wrote:
> heh. LGTM

Besides, the best way to reduce the output is to reduce the rootfs size :-)

I'll push as is...

> 
> On Wed, Nov 3, 2010 at 11:43 AM, <mailto:petkov@chromium.org> wrote:
> 
> >
> > http://codereview.chromium.org/4243006/diff/2001/3001
> > File delta_diff_generator.cc (right):
> >
> > http://codereview.chromium.org/4243006/diff/2001/3001#newcode1381
> > delta_diff_generator.cc:1381: LOG(INFO) << StringPrintf("%.1f", offset *
> > 100.0 / part_sizes[partition])
> > On 2010/11/03 18:41:51, adlr wrote:
> >
> >> how many lines does this produce? Maybe we should print a line less
> >>
> > than every
> >
> >> chunk?
> >>
> >
> > 850 I guess? I'm OK with verbose output as long as it can be interpreted
> > by random devs.
> >
> >
> > http://codereview.chromium.org/4243006/show
> >
>