Issue 4243003: Add chromeos-chrome to rebuild blacklist for faster builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4243003: Add chromeos-chrome to rebuild blacklist for faster builds. (Closed)

Created:
10 years, 1 month ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
Nick Sanders, anush

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git

Visibility:
Public.

Description

Add chromeos-chrome to rebuild blacklist for faster builds. chromeos-chrome has mostly self-contained dependencies, so there usually isn't need to rebuild it just because a dependency changed. This allows for us to use the binaries for chromeos-chrome more often. BUG=chromium-os:8394 TEST=Check that chrome doesn't rebuild with ./parallel_emerge -gp --workon=libcros --board=x86-generic chromeos-chrome Change-Id: Ifa14c890917991a8d11f1f0e757f28686d611a72 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c3874d1

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	parallel_emerge	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

anush

10 years, 1 month ago (2010-11-02 08:23:57 UTC) #2

LGTM

On Tue, Nov 2, 2010 at 1:18 AM,  <davidjames@chromium.org> wrote:
> Reviewers: anush, Nick Sanders,
>
> Description:
> Add chromeos-chrome to rebuild blacklist for faster builds.
>
> chromeos-chrome has mostly self-contained dependencies, so there usually
> isn't need to rebuild it just because a dependency changed. This allows for
> us to use the binaries for chromeos-chrome more often.
>
> BUG=chromium-os:8394
> TEST=Check that chrome doesn't rebuild with
> ./parallel_emerge -gp --workon=libcros --board=x86-generic
> chromeos-chrome
>
> Change-Id: Ifa14c890917991a8d11f1f0e757f28686d611a72
>
> Please review this at http://codereview.chromium.org/4243003/show
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/crosutils.git
>
> Affected files:
>  M parallel_emerge
>
>
> Index: parallel_emerge
> diff --git a/parallel_emerge b/parallel_emerge
> index
>
37214241e17f41150c97790830c8de317d9b5988..acf17fb2d67493130f23a241ba5b8ccf76af4298
> 100755
> --- a/parallel_emerge
> +++ b/parallel_emerge
> @@ -638,7 +638,8 @@ class DepGraphGenerator(object):
>     # are blacklisting them from automatic rebuilds because one of their
>     # dependencies needs to be recompiled.
>     rebuild_blacklist = set()
> -    for pkg in ("media-plugins/o3d", "dev-java/icedtea"):
> +    for pkg in ("chromeos-base/chromeos-chrome", "media-plugins/o3d",
> +                "dev-java/icedtea"):
>       for match in final_db.match_pkgs(pkg):
>         rebuild_blacklist.add(str(match.cpv))
>
>
>
>

Expand Messages | Collapse Messages