Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 42423: Add a public API for using an empty sring. (Closed)

Created:
11 years, 9 months ago by Mike Belshe
Modified:
9 years, 5 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Add a public API for using an empty sring. v8::String::Empty() Committed: http://code.google.com/p/v8/source/detail?r=1556

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M include/v8.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/api.cc View 1 2 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mike Belshe
11 years, 9 months ago (2009-03-19 23:01:52 UTC) #1
Kasper Lund
11 years, 9 months ago (2009-03-19 23:21:24 UTC) #2
LGTM, but I would do 'length == 0' instead of '!length'.

Powered by Google App Engine
This is Rietveld 408576698