Issue 424183004: Update SpellCheckClient to chromium c++ style

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 424183004: Update SpellCheckClient to chromium c++ style (Closed)

Created:
6 years, 4 months ago by Abhishek

Modified:
6 years, 4 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Update SpellCheckClient to chromium c++ style Changes: 1) Run clang-format through source and header files. 2) Rename data member variables to use unix_hacker_ style. 3) Rename methods to use CamelCase style. 4) Rename file name to spell_check_client. BUG=331299 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287117

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+223 lines, -209 lines)			Patch
M	content/content_shell.gypi	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/shell/BUILD.gn	View	2 chunks	+2 lines, -2 lines	0 comments	Download
D	content/shell/renderer/test_runner/SpellCheckClient.h	View	1 chunk	+0 lines, -57 lines	0 comments	Download
D	content/shell/renderer/test_runner/SpellCheckClient.cpp	View	1 chunk	+0 lines, -146 lines	0 comments	Download
A	content/shell/renderer/test_runner/spell_check_client.h	View	1 chunk	+65 lines, -0 lines	0 comments	Download
A	content/shell/renderer/test_runner/spell_check_client.cc	View	1 chunk	+152 lines, -0 lines	0 comments	Download
M	content/shell/renderer/test_runner/web_test_proxy.cc	View	3 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abhishek.a21@samsung.com/424183004/1

6 years, 4 months ago (2014-08-01 08:52:01 UTC) #4

Message was sent while issue was closed.

Change committed as 287117

Expand Messages | Collapse Messages