Fix gcc 4.3 warning in directory_watcher_inotify.cc

Fix gcc 4.3 warning in directory_watcher_inotify.cc

- check return value of write to self-pipe

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12150

[agl, 2009-03-19 18:53:27]

http://codereview.chromium.org/42403/diff/1/2
File base/directory_watcher_inotify.cc (right):

http://codereview.chromium.org/42403/diff/1/2#newcode191
Line 191: ssize_t bytes_written = write(shutdown_pipe_[1], "", 1);
ssize_t bytes_written = 0;
do {
  bytes_written += write(shutdown_pipe_[1], "", 1);
  if (bytes_written == 0)
    continue;
} while (bytes_written == -1 && errno == EINTR);

[Paweł Hajdan Jr., 2009-03-19 18:58:45]

Patch updated.

[Mark Mentovai, 2009-03-19 19:01:57]

http://codereview.chromium.org/42403/diff/4/5
File base/directory_watcher_inotify.cc (right):

http://codereview.chromium.org/42403/diff/4/5#newcode197
Line 197: thread_.Stop();
You can keep the DCHECK that you had in the last version, or update the
changelist description to remove the mention of DCHECK.

I think the DCHECK was fine but I also don't mind if you want to get rid of it.

[agl, 2009-03-19 19:02:37]

LGTM