Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Issue 4240003: Disregard any global 'ignore' settings that the user may have when submitting... (Closed)

Created:
10 years, 1 month ago by erikwright (departed)
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Disregard any global 'ignore' settings that the user may have when submitting try jobs via SVN. BUG=None TEST=Add '*.diff' to 'global-ignores' in your local SVN configuration. Submit a try job using 'gcl try'. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64768

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M trychange.py View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
erikwright (departed)
10 years, 1 month ago (2010-11-02 15:48:56 UTC) #1
M-A Ruel
lgtm with style nit. I wonder if this flags is available on svn 1.4 though. ...
10 years, 1 month ago (2010-11-02 15:50:53 UTC) #2
erikwright (departed)
Modified to only apply for SVN >= 1.5 (which appears to be when --no-ignore was ...
10 years, 1 month ago (2010-11-02 16:55:56 UTC) #3
M-A Ruel
10 years, 1 month ago (2010-11-02 17:07:28 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698