Issue 4240002: Add branch mario preflight with both public and private overlays

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4240002: Add branch mario preflight with both public and private overlays (Closed)

Created:
10 years, 1 month ago by scottz

Modified:
9 years, 7 months ago

Reviewers:
davidjames, anush

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils@master

Visibility:
Public.

Description

Add branch mario preflight with both public and private overlays BUG=NA TEST=NA Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=92a4d1c

Patch Set 1 #

Patch Set 2 : update to remove overlays, missed that overlays isn't the decider here #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	bin/cbuildbot_config.py	View	1	1 chunk	+8 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottz

Set to True to have the if/else set it to private and public overlays for ...

10 years, 1 month ago (2010-11-02 04:55:02 UTC) #1

David James

10 years, 1 month ago (2010-11-02 05:37:36 UTC) #3

http://codereview.chromium.org/4240002/diff/3001/4001
File bin/cbuildbot_config.py (right):

http://codereview.chromium.org/4240002/diff/3001/4001#newcode23
bin/cbuildbot_config.py:23: to. This can be 'public', 'private', or 'both'.
There should only
Here's the docs.

http://codereview.chromium.org/4240002/diff/3001/4001#newcode62
bin/cbuildbot_config.py:62: 'smoke_bvt' : True,
If 'master' is true then 'overlays' needs to be defined. Should be set to 'both'
here or you'll get errors.

Expand Messages | Collapse Messages