Issue 4240001: [cros] migrate to safe ownership API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4240001: [cros] migrate to safe ownership API (Closed)

Created:
10 years, 1 month ago by Chris Masone

Modified:
9 years, 7 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[cros] migrate to safe ownership API I was passing memory from libcros to chrome and expecting chrome to free it. I was also passing vectors across the DLL boundary. These could both cause memory horkage. Having implemented safe alternatives in http://codereview.chromium.org/4132006, migrate to them. Depends on cros_deps roll in http://codereview.chromium.org/4207004/show BUG=chromium-os:8283 TEST=install on the device, log in as the first account, whitelist users, disable BWSI Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64756

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -7 lines)			Patch
	M	chrome/browser/chromeos/cros/login_library.cc	View		5 chunks	+46 lines, -7 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM