Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: pylib/gyp/input.py

Issue 42394: Cleanup remove mac specific type 'application'... (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pylib/gyp/generator/xcode.py ('K') | « pylib/gyp/generator/xcode.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/input.py
===================================================================
--- pylib/gyp/input.py (revision 374)
+++ pylib/gyp/input.py (working copy)
@@ -10,7 +10,7 @@
# A list of types that are treated as linkable.
-linkable_types = ['application', 'executable', 'shared_library']
+linkable_types = ['executable', 'shared_library']
# A list of sections that contain links to other targets.
dependency_sections = ['dependencies', 'export_dependent_settings']
@@ -847,7 +847,7 @@
# Executables are already fully and finally linked. Nothing else can be
# a link dependency of an executable, there can only be dependencies in
# the sense that a dependent target might run an executable.
- if not initial and target_type in ['application', 'executable']:
+ if not initial and target_type == 'executable':
return dependencies
# The target is linkable, add it to the list of link dependencies.
@@ -1166,6 +1166,7 @@
'default_configuration',
'dependencies',
'libraries',
+ 'mac_bundle',
'mac_bundle_resources',
'postbuilds',
'product_dir',
« pylib/gyp/generator/xcode.py ('K') | « pylib/gyp/generator/xcode.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698