Add some UBC eviction code after talking to Amit (and it doesn't even require...

Add some UBC eviction code after talking to Amit (and it doesn't even require
a kext)  :)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12090

[Mark Mentovai, 2009-03-19 14:50:07]

L(ooks) good to me on the code.

L(ess) good on the comments.

http://codereview.chromium.org/42391/diff/1/2
File base/test_file_util_mac.cc (right):

http://codereview.chromium.org/42391/diff/1/2#newcode7
Line 7: #include <sys/mman.h>
Come on, what alphabet are we using today?

http://codereview.chromium.org/42391/diff/1/2#newcode16
Line 16: // talking w/ Amit Singh, the safest is to mmap the file, do a msync to
I would do "an" msync unless you have a novel way to pronounce msync that
doesn't start with "em."

Also, this could be revised to be a little clearer, like by putting "then"
before "do."

http://codereview.chromium.org/42391/diff/1/2#newcode20
Line 20: // We use MemoryMappedFile because it mmaps MAP_FILE | MAP_SHARED (it
doesn't
That's kind of obvious from reading MemoryMappedFile::MapFileToMemory.  This
comment isn't contributing anything really except implying that MAP_FILE |
MAP_SHARED is needed to make this scheme work.  Is it?  If so, it ought to be
explicit.

http://codereview.chromium.org/42391/diff/1/2#newcode24
Line 24: file_util::MemoryMappedFile mmap;
I would not name a variable mmap, mmap is the name of a system call and this is
confusing.