Add support for different type of encyrption when adding a network....

Add support for different type of encyrption when adding a network.
BUG=chromium-os:8193
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64808

[xiyuan, 2010-11-02 19:41:55]

LGTM

[stevenjb, 2010-11-02 19:48:13]

http://codereview.chromium.org/4237001/diff/19001/20002
File chrome/browser/chromeos/cros/network_library.cc (right):

http://codereview.chromium.org/4237001/diff/19001/20002#newcode715
chrome/browser/chromeos/cros/network_library.cc:715: ssid, password, identity,
certpath, auto_connect);
It might be better to eliminate this function and add the logic explicitly where
we call it?

http://codereview.chromium.org/4237001/diff/19001/20003
File chrome/browser/chromeos/cros/network_library.h (right):

http://codereview.chromium.org/4237001/diff/19001/20003#newcode439
chrome/browser/chromeos/cros/network_library.h:439: bool auto_connect) = 0;
Do we need both of these, or could we always use the second one?

http://codereview.chromium.org/4237001/diff/19001/20005
File chrome/browser/chromeos/options/wifi_config_view.cc (right):

http://codereview.chromium.org/4237001/diff/19001/20005#newcode101
chrome/browser/chromeos/options/wifi_config_view.cc:101:
!passphrase_textfield_->text().empty());
I saw another CL where we enforce passphrase length based on security type,
maybe for settings? We should put that logic into network_library and use it,
something like netlib->CheckPassphraseLength(security, passphrase).

[Charlie Lee, 2010-11-02 20:01:51]

http://codereview.chromium.org/4237001/diff/19001/20002
File chrome/browser/chromeos/cros/network_library.cc (right):

http://codereview.chromium.org/4237001/diff/19001/20002#newcode715
chrome/browser/chromeos/cros/network_library.cc:715: ssid, password, identity,
certpath, auto_connect);
Ok, since the only one left is from network_menu, I will put that logic there.
When we go back to using DOM ui, we need to fix network_menu to have the
security selection combobox.

On 2010/11/02 19:48:13, Steven Bennetts wrote:
> It might be better to eliminate this function and add the logic explicitly
where
> we call it?
>

http://codereview.chromium.org/4237001/diff/19001/20003
File chrome/browser/chromeos/cros/network_library.h (right):

http://codereview.chromium.org/4237001/diff/19001/20003#newcode439
chrome/browser/chromeos/cros/network_library.h:439: bool auto_connect) = 0;
On 2010/11/02 19:48:13, Steven Bennetts wrote:
> Do we need both of these, or could we always use the second one?

Done.

http://codereview.chromium.org/4237001/diff/19001/20005
File chrome/browser/chromeos/options/wifi_config_view.cc (right):

http://codereview.chromium.org/4237001/diff/19001/20005#newcode101
chrome/browser/chromeos/options/wifi_config_view.cc:101:
!passphrase_textfield_->text().empty());
Yes, I believe there's a bug on that issue. For now, I won't fix it here.

On 2010/11/02 19:48:13, Steven Bennetts wrote:
> I saw another CL where we enforce passphrase length based on security type,
> maybe for settings? We should put that logic into network_library and use it,
> something like netlib->CheckPassphraseLength(security, passphrase).

[stevenjb, 2010-11-02 20:24:24]

On 2010/11/02 20:01:51, Charlie Lee wrote:
> When we go back to using DOM ui, we need to fix network_menu to have the
> security selection combobox.

Yes, we'll want to figure out if/how we want to to this.

> Yes, I believe there's a bug on that issue. For now, I won't fix it here.
> 
Fair enough.

LGTM