[ChromeOS] Implement new progress bar mock.

[ChromeOS] Implement new progress bar mock.

BUG=chromium-os:8465
TEST=Verify progress bar has new look now per chromium-os:8465.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64924

[sky, 2010-11-01 21:42:15]

http://codereview.chromium.org/4236001/diff/1/2
File views/controls/progress_bar.cc (right):

http://codereview.chromium.org/4236001/diff/1/2#newcode29
views/controls/progress_bar.cc:29: static void AddRoundRectPathWithPadding(int
x, int y,
You should create a progress_bar_chromeos and put this painting code there. Have
a #ifdef here for !chromeos that does the existing painting.

http://codereview.chromium.org/4236001/diff/1/2#newcode169
views/controls/progress_bar.cc:169: 
nit: remove this line.

[xiyuan, 2010-11-01 23:02:19]

http://codereview.chromium.org/4236001/diff/1/2
File views/controls/progress_bar.cc (right):

http://codereview.chromium.org/4236001/diff/1/2#newcode29
views/controls/progress_bar.cc:29: static void AddRoundRectPathWithPadding(int
x, int y,
On 2010/11/01 21:42:15, sky wrote:
> You should create a progress_bar_chromeos and put this painting code there.
Have
> a #ifdef here for !chromeos that does the existing painting.

AddRoundRectPathWithPadding is adapted from AddRoundRectPath code and needed by
AddRoundRectPath down below. It's not chromeos specific.

http://codereview.chromium.org/4236001/diff/1/2#newcode169
views/controls/progress_bar.cc:169: 
On 2010/11/01 21:42:15, sky wrote:
> nit: remove this line.

Done.

[sky, 2010-11-01 23:05:32]

LGTM

http://codereview.chromium.org/4236001/diff/1/2
File views/controls/progress_bar.cc (right):

http://codereview.chromium.org/4236001/diff/1/2#newcode29
views/controls/progress_bar.cc:29: static void AddRoundRectPathWithPadding(int
x, int y,
On 2010/11/01 23:02:19, xiyuan wrote:
> On 2010/11/01 21:42:15, sky wrote:
> > You should create a progress_bar_chromeos and put this painting code there.
> Have
> > a #ifdef here for !chromeos that does the existing painting.
> 
> AddRoundRectPathWithPadding is adapted from AddRoundRectPath code and needed
by
> AddRoundRectPath down below. It's not chromeos specific.

Ah, I missed that.