Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 42360: Fix a UMR error in chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc (Closed)

Created:
11 years, 9 months ago by Alpha Left Google
Modified:
9 years, 6 months ago
Reviewers:
Peter Kasting, jam
CC:
chromium-reviews_googlegroups.com, agl, M-A Ruel, Dean McNamee
Visibility:
Public.

Description

CreateResourceRequest() in chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc is not updated when |request_context| is added to ViewHostMsg_Resource_Request. In r11816 CreateResourceRequest() is used to prepare ViewHostMsg_Resource_Request with |request_context| uninitialized, giving the purify bot red. Initializing the variable should fix the UMR error.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alpha Left Google
Detail stack trace: chrome/common/ipc_message_utils.h:182 IPC::ParamTraits::Write(Message::IPC *,UINT const&) chrome/common/ipc_message_utils.h:123 IPC::WriteParam chrome/common/render_messages.h:1257 IPC::ParamTraits::Write(Message::IPC *,ViewHostMsg_Resource_Request const&) chrome/common/ipc_message_utils.h:123 IPC::WriteParam ...
11 years, 9 months ago (2009-03-18 21:27:23 UTC) #1
Peter Kasting
LGTM as an emergency fix, but shouldn't ViewHostMsg_Resource_Request have a NULL constructor that inits all ...
11 years, 9 months ago (2009-03-18 22:54:43 UTC) #2
Alpha Left Google
On 2009/03/18 22:54:43, pkasting wrote: > LGTM as an emergency fix, but shouldn't ViewHostMsg_Resource_Request have ...
11 years, 9 months ago (2009-03-18 23:03:44 UTC) #3
Peter Kasting
11 years, 9 months ago (2009-03-18 23:08:31 UTC) #4
On 2009/03/18 23:03:44, Alpha wrote:
> I don't see such a constructor for ViewHostMsg_Resource_Request, in fact all
the
> struct in chrome/common/renderer_messages.h don't have default ctor.

I'm suggesting adding one.

Powered by Google App Engine
This is Rietveld 408576698