Fix a UMR error in chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

CreateResourceRequest() in
chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
is not updated when |request_context| is added to
ViewHostMsg_Resource_Request.

In r11816 CreateResourceRequest() is used to prepare
ViewHostMsg_Resource_Request with |request_context| uninitialized,
giving the purify bot red. Initializing the variable should fix the
UMR error.

[Alpha Left Google, 2009-03-18 21:27:23]

Detail stack trace:
   chrome/common/ipc_message_utils.h:182
       IPC::ParamTraits::Write(Message::IPC *,UINT const&)
   chrome/common/ipc_message_utils.h:123
       IPC::WriteParam
   chrome/common/render_messages.h:1257
       IPC::ParamTraits::Write(Message::IPC *,ViewHostMsg_Resource_Request
const&)
   chrome/common/ipc_message_utils.h:123
       IPC::WriteParam
   chrome/common/ipc_message_utils.h:1031
       IPC::ParamTraits::Write(Message::IPC *,Tuple2 const&)
   chrome/common/ipc_message_utils.h:123
       IPC::WriteParam
   chrome/common/ipc_message_utils.h:1169
       IPC::MessageWithTuple::MessageWithTuple(int,WORD,Tuple2 const&)
   chrome/common/render_messages_internal.h:691
        ViewHostMsg_RequestResource::ViewHostMsg_RequestResource(int,int
const&,ViewHostMsg_Resource_Request const&)
   chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc:171 
ResourceDispatcherHostTest::MakeTestRequest(Receiver::ResourceDispatcherHost
*,int,int,int,GURL const&)
   chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc:159 
ResourceDispatcherHostTest::MakeTestRequest(int,int,int,GURL const&)
   chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc:466 
ResourceDispatcherHostTest_TestBlockedRequestsProcessDies_Test::TestBody(void)
   testing/gtest/src/gtest.cc:2010  testing::Test::Run(void)

[Peter Kasting, 2009-03-18 22:54:43]

LGTM as an emergency fix, but shouldn't ViewHostMsg_Resource_Request have a NULL
constructor that inits all these members, so that this function can be
mostly/completely eliminated?

[Alpha Left Google, 2009-03-18 23:03:44]

On 2009/03/18 22:54:43, pkasting wrote:
> LGTM as an emergency fix, but shouldn't ViewHostMsg_Resource_Request have a
NULL
> constructor that inits all these members, so that this function can be
> mostly/completely eliminated?

I don't see such a constructor for ViewHostMsg_Resource_Request, in fact all the
struct in chrome/common/renderer_messages.h don't have default ctor.

[Peter Kasting, 2009-03-18 23:08:31]

On 2009/03/18 23:03:44, Alpha wrote:
> I don't see such a constructor for ViewHostMsg_Resource_Request, in fact all
the
> struct in chrome/common/renderer_messages.h don't have default ctor.

I'm suggesting adding one.