This is a fix of issue http://b/issue?id=1381845....

This is a fix of issue http://b/issue?id=1381845.

Check domain security on prototypes in for-in loop.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=368

[Mads Ager (chromium), 2008-09-24 06:09:20]

LGTM

http://codereview.chromium.org/4236/diff/1/2
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/4236/diff/1/2#newcode3193
Line 3193: Script::Compile(v8_str("(function(){var obj = {'__proto__':env1};\
I find it easier to read if you do not use \ and instead use the fact that
adjacent string literals are concatenated.

"function() {"
"  var obj = {'__proto__':env1};"
"  for (var p in obj)"
...

Also, you could use the CompileRun helper function.  We really should clean up
test-api.  I see that we have both v8_compile and CompileRun helper functions -
we should only have one and use it consistently.  Feel free to put this back
without doing that though.

[Feng Qian, 2008-09-24 15:30:26]

http://codereview.chromium.org/4236/diff/1/2
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/4236/diff/1/2#newcode3193
Line 3193: Script::Compile(v8_str("(function(){var obj = {'__proto__':env1};\
On 2008/09/24 06:09:21, Mads Ager wrote:
> I find it easier to read if you do not use \ and instead use the fact that
> adjacent string literals are concatenated.
> 
> "function() {"
> "  var obj = {'__proto__':env1};"
> "  for (var p in obj)"
> ...
> 
> Also, you could use the CompileRun helper function.  We really should clean up
> test-api.  I see that we have both v8_compile and CompileRun helper functions
-
> we should only have one and use it consistently.  Feel free to put this back
> without doing that though. 
> 

Done.