Issue 42355: Switching sandbox to gyp on windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42355: Switching sandbox to gyp on windows. (Closed)

Created:
11 years, 9 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Switching sandbox to gyp on windows. Rolling forward deps on gyp to get 'copies' support. This time handled wow_helper. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12270

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -128 lines)			Patch
M	DEPS	View	2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	build/all.gyp	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/chrome.sln	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sandbox/sandbox.gyp	View	2 3	1 chunk	+9 lines, -0 lines	0 comments	Download
D	sandbox/sandbox.sln	View	1	1 chunk	+0 lines, -127 lines	0 comments	Download
A +	sandbox/sandbox_standalone.sln	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bradn

This moves the old sln to _standalone. Also this time I believe I've handled wow_helper ...

11 years, 9 months ago (2009-03-22 22:39:55 UTC) #1

Mark Mentovai

11 years, 9 months ago (2009-03-22 22:59:20 UTC) #2

LG, good luck

http://codereview.chromium.org/42355/diff/2007/14
File sandbox/sandbox.gyp (right):

http://codereview.chromium.org/42355/diff/2007/14#newcode153
Line 153: 'wow_helper/wow_helper.exe',
Since these are listed here, do they need to be in the sources list too?  Won't
they be added to the vcproj anyway?

Expand Messages | Collapse Messages