Chromium Code Reviews

Unified Diff: chrome/browser/chromeos/network_message_observer.cc

Issue 4235005: Push for ers:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: chrome/browser/chromeos/network_message_observer.cc
===================================================================
--- chrome/browser/chromeos/network_message_observer.cc (revision 64886)
+++ chrome/browser/chromeos/network_message_observer.cc (working copy)
@@ -35,11 +35,19 @@
notification_no_data_(profile, "network_no_data.chromeos",
IDR_NOTIFICATION_BARS_EMPTY,
l10n_util::GetStringUTF16(IDS_NETWORK_OUT_OF_DATA_TITLE)) {
- NetworkChanged(CrosLibrary::Get()->GetNetworkLibrary());
+ NetworkLibrary* netlib = CrosLibrary::Get()->GetNetworkLibrary();
+ OnNetworkManagerChanged(netlib);
+ // Note that this gets added as a NetworkManagerObserver and a
+ // CellularDataPlanObserver in browser_init.cc
+ netlib->AddNetworkManagerObserver(this);
+ netlib->AddCellularDataPlanObserver(this);
initialized_ = true;
}
NetworkMessageObserver::~NetworkMessageObserver() {
+ NetworkLibrary* netlib = CrosLibrary::Get()->GetNetworkLibrary();
+ netlib->RemoveNetworkManagerObserver(this);
+ netlib->RemoveCellularDataPlanObserver(this);
notification_connection_error_.Hide();
notification_low_data_.Hide();
notification_no_data_.Hide();
@@ -65,7 +73,7 @@
BrowserList::GetLastActive()->OpenMobilePlanTabAndActivate();
}
-void NetworkMessageObserver::NetworkChanged(NetworkLibrary* obj) {
+void NetworkMessageObserver::OnNetworkManagerChanged(NetworkLibrary* obj) {
const WifiNetworkVector& wifi_networks = obj->wifi_networks();
const CellularNetworkVector& cellular_networks = obj->cellular_networks();
@@ -150,7 +158,7 @@
CreateModalPopup(view);
}
-void NetworkMessageObserver::CellularDataPlanChanged(NetworkLibrary* obj) {
+void NetworkMessageObserver::OnCellularDataPlanChanged(NetworkLibrary* obj) {
const CellularNetwork* cellular = obj->cellular_network();
if (!cellular)
return;
« no previous file with comments | « chrome/browser/chromeos/network_message_observer.h ('k') | chrome/browser/chromeos/network_state_notifier.h » ('j') | no next file with comments »

Powered by Google App Engine