Issue 4235001: Fix versioning logic in ctest to get the correct latest version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4235001: Fix versioning logic in ctest to get the correct latest version. (Closed)

Created:
10 years, 1 month ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

Fix versioning logic in ctest to get the correct latest version. Change-Id: I2721bcd2da38b764ebe21dfb8fe7a39dd947075c BUG=8500 TEST=Ran it against all boards Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b4b09d4

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nit #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	bin/ctest.py	View	1	2 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 1 month ago (2010-11-01 21:33:41 UTC) #2

LGTM w/ a suggestion

http://codereview.chromium.org/4235001/diff/1/2
File bin/ctest.py (right):

http://codereview.chromium.org/4235001/diff/1/2#newcode105
bin/ctest.py:105: else: return version_b
you don't need the "else:" here

Expand Messages | Collapse Messages