Issue 42328: Revert 11946 since it is causing a build breakage on full rebuild. The ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42328: Revert 11946 since it is causing a build breakage on full rebuild. The ... (Closed)

Created:
11 years, 9 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
rvargas (doing something else), bradn

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Revert 11946 since it is causing a build breakage on full rebuild. The sandbox project wasn't copying wow_helper.exe anymore, causing a build breakage on x64 platforms only. TBR=bnelson Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11955

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -6 lines)			Patch
	M	build/all.gyp	View		1 chunk	+0 lines, -5 lines	0 comments	Download
	M	chrome/chrome.sln	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Adding rvargas as a reminder to Never Ever use post build steps again. This thing ...

11 years, 9 months ago (2009-03-18 12:19:33 UTC) #3

bradn

This seems to be missing the sandbox.vcproj ? Maybe the generated one blocked the revert?

11 years, 9 months ago (2009-03-18 17:06:11 UTC) #4

M-A Ruel

11 years, 9 months ago (2009-03-18 17:23:24 UTC) #5

On 2009/03/18 17:06:11, bradn wrote:
> This seems to be missing the sandbox.vcproj ?
> Maybe the generated one blocked the revert?

It is a gcl error since sandbox.sln is in the commit.

Expand Messages | Collapse Messages