Issue 4231001: Chromium part of the autofill refactor: removing now unused code....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4231001: Chromium part of the autofill refactor: removing now unused code.... (Closed)

Created:
10 years, 1 month ago by Jay Civelli

Modified:
9 years, 7 months ago

Reviewers:
Ilya Sherman, dhollowa

CC:
chromium-reviews, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Chromium part of the autofill refactor: removing now unused code. BUG=None TEST=All tests should pass. Autocomplete/autofill should still work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64797

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -214 lines)			Patch
M	chrome/renderer/password_autocomplete_manager_unittest.cc	View		6 chunks	+6 lines, -24 lines	0 comments	Download
M	chrome/renderer/render_view.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 2	6 chunks	+0 lines, -18 lines	0 comments	Download
M	webkit/glue/dom_operations.h	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	webkit/glue/dom_operations.cc	View		2 chunks	+3 lines, -162 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

LGTM, too http://codereview.chromium.org/4231001/diff/6001/7002 File chrome/renderer/render_view.cc (right): http://codereview.chromium.org/4231001/diff/6001/7002#newcode2375 chrome/renderer/render_view.cc:2375: } nit: Can we get rid of ...

10 years, 1 month ago (2010-11-02 15:36:14 UTC) #3

Jay Civelli

10 years, 1 month ago (2010-11-02 16:26:47 UTC) #4

On 2010/11/02 15:36:14, Ilya Sherman wrote:
> LGTM, too
> 
> http://codereview.chromium.org/4231001/diff/6001/7002
> File chrome/renderer/render_view.cc (right):
> 
> http://codereview.chromium.org/4231001/diff/6001/7002#newcode2375
> chrome/renderer/render_view.cc:2375: }
> nit: Can we get rid of this whole method, rather than just the method body?

Good point, method removed.
I'll will land the CL soon.

Expand Messages | Collapse Messages