Break up unit test to avoid internal timing interactions between parts....

base/watchdog_unittest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Tests for Watchdog class.
 
 #include "base/platform_thread.h"
 #include "base/spin_wait.h"
 #include "base/time.h"
 #include "base/watchdog.h"
@@ skipping 57 matching lines @@
   watchdog2.Disarm();
 }
 
 // Make sure a basic alarm fires when the time has expired.
 TEST(WatchdogTest, AlarmTest) {
   WatchdogCounter watchdog(TimeDelta::FromMilliseconds(10), "Enabled", true);
   watchdog.Arm();
   SPIN_FOR_TIMEDELTA_OR_UNTIL_TRUE(TimeDelta::FromMinutes(5),
                                    watchdog.alarm_counter() > 0);
   EXPECT_EQ(1, watchdog.alarm_counter());
+}
 
-  // Set a time greater than the timeout into the past.
+// Make sure a basic alarm fires when the time has expired.

[wtc, 2009/06/04 23:14:24]

This comment should show how AlarmPriorTimeTest differs from
AlarmTest.  This comment is exactly the same as the comment on
line 71!

+TEST(WatchdogTest, AlarmPriorTimeTest) {
+  WatchdogCounter watchdog(TimeDelta::TimeDelta(), "Enabled2", true);

[wtc, 2009/06/04 23:14:24]

Why is the first argument TimeDelta::TimeDelta() instead
of TimeDelta::FromMilliseconds(10) or something like that?

Why can't this watchdog be named "Enabled"?  You didn't
changed the "Enabled" names in StartupShutdownTest and
ArmDisarmTest.

+  // Set a time in the past.
   watchdog.ArmSomeTimeDeltaAgo(TimeDelta::FromSeconds(2));
   // It should instantly go off, but certainly in less than 5 minutes.
   SPIN_FOR_TIMEDELTA_OR_UNTIL_TRUE(TimeDelta::FromMinutes(5),
-                                   watchdog.alarm_counter() > 1);
+                                   watchdog.alarm_counter() > 0);
 
-  EXPECT_EQ(2, watchdog.alarm_counter());
+  EXPECT_EQ(1, watchdog.alarm_counter());
 }
 
 // Make sure a disable alarm does nothing, even if we arm it.
 TEST(WatchdogTest, ConstructorDisabledTest) {
   WatchdogCounter watchdog(TimeDelta::FromMilliseconds(10), "Disabled", false);
   watchdog.Arm();
   // Alarm should not fire, as it was disabled.
   PlatformThread::Sleep(500);
   EXPECT_EQ(0, watchdog.alarm_counter());
 }
 
 // Make sure Disarming will prevent firing, even after Arming.
 TEST(WatchdogTest, DisarmTest) {
-  WatchdogCounter watchdog(TimeDelta::FromSeconds(5), "Enabled", true);
+  WatchdogCounter watchdog(TimeDelta::FromSeconds(5), "Enabled3", true);
   watchdog.Arm();
   PlatformThread::Sleep(100);  // Don't sleep too long
   watchdog.Disarm();
   // Alarm should not fire.
   PlatformThread::Sleep(5500);
   EXPECT_EQ(0, watchdog.alarm_counter());
 
   // ...but even after disarming, we can still use the alarm...
   // Set a time greater than the timeout into the past.
   watchdog.ArmSomeTimeDeltaAgo(TimeDelta::FromSeconds(2));
   // It should almost instantly go off, but certainly in less than 5 minutes.
   SPIN_FOR_TIMEDELTA_OR_UNTIL_TRUE(TimeDelta::FromMinutes(5),
                                    watchdog.alarm_counter() > 0);
 
   EXPECT_EQ(1, watchdog.alarm_counter());
 }
 
 }  // namespace