Issue 42263: SSL Fix: Step 4....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42263: SSL Fix: Step 4.... (Closed)

Created:
11 years, 9 months ago by abarth-chromium

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

SSL Fix: Step 4. Plumb the security origin information for memory cache loads too. R=wtc BUG=8706 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11850

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -11 lines)			Patch
M	chrome/browser/load_from_memory_cache_details.h	View		1 chunk	+15 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_view_host_delegate.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/web_contents.h	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/common/render_messages_internal.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 2 3	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wtc

11 years, 9 months ago (2009-03-16 23:51:18 UTC) #2

LGTM.

http://codereview.chromium.org/42263/diff/1017/1022
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/42263/diff/1017/1022#newcode1267
Line 1267: frame->GetTop()->GetSecurityOrigin() : "null";
Is it possible to have a constant or a function that returns
"null" as the null security origin?  You also have that string
literal in GetSecurityOrigin().

Perhaps frame->GetTop() cannot return NULL here?  It only
returns NULL if frame->frame_ is NULL.

Expand Messages | Collapse Messages