Add the directory listing code for the new portable...

Add the directory listing code for the new portable FTP
implementation, based on the Mozilla code
mozilla/netwerk/streamconv/converters/ParseFTPList.cpp.

Contributed by Ibrar Ahmed <ibrar.ahmad@gmail.com>;.

R=darin,wtc
BUG=4965
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12171

[wtc, 2009-03-19 22:29:49]

Hi Ibrar,

I created this CL based on your CL
http://codereview.chromium.org/28298

Please review the changes I made, described below.

I will check this CL in after it passes the tests on
the try servers.

http://codereview.chromium.org/42261/diff/1/3
File net/ftp/ftp_directory_parser.cc (right):

http://codereview.chromium.org/42261/diff/1/3#newcode47
Line 47: #include <time.h>
I removed <time.h> from the .cc file because you added it
to the .h file.

http://codereview.chromium.org/42261/diff/1/3#newcode159
Line 159: // TODO(ibrar): Yet thought required here
I removed the TODO(ibrar) above gmtime_s/gmtime_r because
I believe you have already addressed it.

http://codereview.chromium.org/42261/diff/1001/7#newcode62
Line 62: namespace net {
I define the gmtime_r function for Windows to eliminate the
ifdefs later in the file.

http://codereview.chromium.org/42261/diff/1001/7#newcode175
Line 175: } else if (isalpha(*p)) {
Some of the code in this file is over-indented.  Here is an
example.  This block is indented by 4 (should be 2).  I'll
let you fix these indentation problems after I check this
in.

http://codereview.chromium.org/42261/diff/1001/7#newcode189
Line 189: if (!result->fe_type) {
This "else if" and the "else" below are also indented wrong.

http://codereview.chromium.org/42261/diff/1001/7#newcode449
Line 449: tbuf[1] == month_names[pos + 1] &&
I found that base/string_util.h has base::snprintf, so I
use it instead of sprintf_s/snprintf, eliminating another
ifdef.

http://codereview.chromium.org/42261/diff/1001/6
File net/ftp/ftp_directory_parser.h (right):

http://codereview.chromium.org/42261/diff/1001/6#newcode41
Line 41: #ifndef NET_FTP_FTP_DIRECTORY_PARSER_H_
I changed the header include guard from
  NET_FTP_DIRECTORY_PARSER_H_
to
  NET_FTP_FTP_DIRECTORY_PARSER_H_
because it needs to match the file's pathname
net/ftp/ftp_directory_parser.h.