Issue 4226001: Implement DOM UI version of keyboard overlay.

Issue 4226001: Implement DOM UI version of keyboard overlay. (Closed)

Created:
10 years, 1 month ago by mazda

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, arv (Not doing code reviews), davemoore+watch_chromium.org, ben+cc_chromium.org, satorux

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Implement DOM UI version of keyboard overlay. Add a URL chrome://keyboardoverlay/ for keyboard overlay. BUG=chromium-os:6268 TEST=manually on the net book Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65028

Patch Set 1 #

Total comments: 40

Patch Set 2 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24061 lines, -0 lines)			Patch
M	chrome/app/generated_resources.grd	View	1	1 chunk	+228 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_resources.grd	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/dom_ui/keyboard_overlay_ui.h	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/dom_ui/keyboard_overlay_ui.cc	View	1	1 chunk	+281 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/dom_ui_factory.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/keyboard_overlay.css	View	1	1 chunk	+158 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/keyboard_overlay.html	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/keyboard_overlay.js	View	1	1 chunk	+406 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/keyboard_overlay_data.js	View		1 chunk	+22941 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/url_constants.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/common/url_constants.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

http://codereview.chromium.org/4226001/diff/1/4 File chrome/browser/chromeos/dom_ui/keyboard_overlay_ui.cc (right): http://codereview.chromium.org/4226001/diff/1/4#newcode46 chrome/browser/chromeos/dom_ui/keyboard_overlay_ui.cc:46: public base::SupportsWeakPtr<KeyboardOverlayHandler> { long line http://codereview.chromium.org/4226001/diff/1/4#newcode255 chrome/browser/chromeos/dom_ui/keyboard_overlay_ui.cc:255: make_scoped_refptr(new DOMUIFavIconSource(dom_ui->GetProfile())))); ...

10 years, 1 month ago (2010-11-01 22:11:22 UTC) #2

mazda

Thanks for the speedy review! http://codereview.chromium.org/4226001/diff/1/4 File chrome/browser/chromeos/dom_ui/keyboard_overlay_ui.cc (right): http://codereview.chromium.org/4226001/diff/1/4#newcode46 chrome/browser/chromeos/dom_ui/keyboard_overlay_ui.cc:46: public base::SupportsWeakPtr<KeyboardOverlayHandler> { On ...

10 years, 1 month ago (2010-11-02 10:34:04 UTC) #3

LGTM

Expand Messages | Collapse Messages